tt140 dev to main #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature # Background [Fetch Retry][1] is a new optional feature under fetch keepalive API. # Changes - Added corresponding fields into fetch keepalive's UKM logging, which was reviewed in [2]. - Removed state transition DCHECKs entirely from `content/public/browser/keep_alive_request_tracker.cc`. The reason is that the new `kRequestRetried` stage can happen in between any stages. Now it doesn't make sense to enumerate them all statically. Plus, there is no harm if unexpected transition happens as this file is entirely for UKM logging purpose. [1]: https://docs.google.com/document/d/1C9lAn3tqXsrjxiid1qCC9qSL7jfA1PZdoo2lgL8L5Pw/edit?tab=t.0#heading=h.4f6c143xmnaj [2]: https://docs.google.com/document/d/1TSbtp5I5Bc1pbAKrrEHfmZlAwgeh6AlgAH7GbDMNPRQ/edit?tab=t.0 (cherry picked from commit 5be55f3) Bug: 417930271,435073483 Change-Id: I0043a626557f407b4c93e020a8c807adbc733d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782231 Reviewed-by: Dmitry Gozman <[email protected]> Commit-Queue: Ming-Ying Chung <[email protected]> Reviewed-by: Robert Kaplow <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1493247} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6826903 Reviewed-by: Arthur Sonzogni <[email protected]> Auto-Submit: Ming-Ying Chung <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2543} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Original change's description: > [Progress bar] Remove circular end indicator > > The circle at the end looks like a bug and doesn't seem to be necessary. > > Screen recording: > http://screencast/cast/NDg0NzczOTUyNjQ0NzEwNHxhODQzZmEyMC05OA > > Bug: 434726022 > Change-Id: I46b92cf247e9806792161c5d64c84b600a804ec5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6792230 > Commit-Queue: Gazal Agarwal <[email protected]> > Reviewed-by: Wenyu Fu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1493105} Bug: 434939594,434726022 Change-Id: I46b92cf247e9806792161c5d64c84b600a804ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6829927 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2544} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Merge-Approval-Bypass: Chrome release infra Change-Id: I239bd3efcf37ec59e9254eade516d461ef17d073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6830443 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2545} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Original change's description: > Fix logging issue in AutofillManagerWrapper with @DoNotInline > > Despite DoNotStripLogs, the logs were not available on a > release build due to inlining. > > Fixed: 430830643 > Change-Id: Icf17e32af7774c8749610bf37e487a6300ab7aa4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6726596 > Reviewed-by: Jan Keitel <[email protected]> > Commit-Queue: Adem Derinel <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1485496} Bug: 435105100,430830643 Change-Id: Icf17e32af7774c8749610bf37e487a6300ab7aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6829827 Reviewed-by: Ioana Pandele <[email protected]> Commit-Queue: Adem Derinel <[email protected]> Commit-Queue: Ioana Pandele <[email protected]> Reviewed-by: Friedrich Hauser <[email protected]> Reviewed-by: Adem Derinel <[email protected]> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2546} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Uploaded by https://ci.chromium.org/b/8707149398174387889 CrOS-LKGM: 16328.45.0 Merge-Approval-Bypass: Automated LKGM update Cr-Original-Build-Id: 8707149398174387889 Change-Id: I0c9b3d35e317acffdfead10cbe94a2b6fc64e33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6832344 Bot-Commit: ChromeOS Release Bot (Robot) <[email protected]> Commit-Queue: ChromeOS Release Bot (Robot) <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2547} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll src/ios_internal in M139 from b99b1a6e42f7 to a7e5f62144c0 Commits rolled: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/b99b1a6e42f7..a7e5f62144c0 Generated by: http://go/bbid/8707097669080568481 Change-Id: If03c51a6b26c656dbd480bdaecbe549ce1be7309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6832244 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2548} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
This change removes 2 CHECK(base::NotFatalUntil::M140)s in StorageServiceImpl. In M139 these evaluate to DumpWithoutCrashing. We already removed similar code in main in crrev.com/c/6808696 after collecting and evaluating Storage process crash keys from Canary/Dev clients. The code in main diverged after the M139 branch point. As such, a direct cherry pick of the above commit into M139 is not possible. Thanks to what we learned using the crash keys, we know these CHECKs in M139 are no longer needed. Additionally, they are exhibiting a CPM of 0.9 per the linked bug. So, this change removes them. Bug: 436618092 Fixed: 436951983 Change-Id: I44009fa5bf762a07954e3c1e48d2d3479536511a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825789 Commit-Queue: Evan Stade <[email protected]> Reviewed-by: Steve Becker <[email protected]> Reviewed-by: Evan Stade <[email protected]> Auto-Submit: Rahul Singh <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2549} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Original change's description: > [ntp-composebox] Transition opacity over 1s > > The transition from background to composebox scrim background was too > jarring. This CL fades the background in by increasing the opacity over > 1s. Also fixes a bug where the text would not populate the searchbox > when the composebox is closed 2 or more times. > > Light theme: http://screencast/cast/NTM4MjkzOTY5NjE2ODk2MHxmNTEwMDcwZC00NA > Dark theme: http://screencast/cast/NTUxNjUwOTA4NTQzMzg1Nnw1Mzg4MDUyYy0zNQ > Dark theme + Dark Background: http://screencast/cast/NjUyNDU0NjE2NDE5NTMyOHwzNjBkOGEwYy01ZQ > Light theme + Dark Background: http://screencast/cast/NTI5ODMzNDUxMTEzNjc2OHw0NmVjMjE0YS1kMw > > Closing animation: > http://screencast/cast/NTA1NTkxMzgzOTgyMDgwMHw0YzM2MTUyNy0wNQ > > Bug: 434721919 > Change-Id: Idfda0ce6233bdcdaa5ef3e9b97a0d15c93837ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6798286 > Reviewed-by: Riley Tatum <[email protected]> > Reviewed-by: Roman Arora <[email protected]> > Commit-Queue: Marlon Facey <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1496626} Bug: 436354240,434721919 Change-Id: Idfda0ce6233bdcdaa5ef3e9b97a0d15c93837ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6832085 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2550} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Original change's description: > [ntp-composebox] Disable click during opening/closing transition > > Switch to using transitions and setting pointer events to disable clicks during transitions as chrome was crashing when a user tries to close > during either of the transitions. Also enables clicks once the > composebox has initialized. > > Screencast: http://screencast/cast/NDc4NTcwODk1Nzk1ODE0NHwwYWQ1NGRlNi1kMA > > Bug: 436817732 > Change-Id: I6d3430dfd60bdbf0844a1b91c9e192047aef9430 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6824906 > Reviewed-by: Roman Arora <[email protected]> > Commit-Queue: Marlon Facey <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1497822} Bug: 436354240,436817732 Change-Id: I6d3430dfd60bdbf0844a1b91c9e192047aef9430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6830060 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2551} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
M139 Merge: Fails on M139. The previous fix (crrev/6802383) turned out to be unsuccessful, and I have no idea why. I think it's best to disable the test for now, until a person with expertise in the domain could take a look. (cherry picked from commit 2f0abdd) Bug: 434716727 Fixed: 437196655 Change-Id: Ia3772d30cb0cabc797abf951ec1a37f4ab168337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6814230 Commit-Queue: Balazs Engedy <[email protected]> Auto-Submit: Mikita Kuchyn <[email protected]> Reviewed-by: Vasilii Sukhanov <[email protected]> Reviewed-by: Balazs Engedy <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1496227} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6829389 Commit-Queue: Robert Liao <[email protected]> Owners-Override: Robert Liao <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2552} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll src/third_party/angle in M139 from 0145c376fadd to 5f3636345f1d Commits rolled: https://chromium.googlesource.com/angle/angle.git/+log/0145c376fadd..5f3636345f1d Generated by: http://go/bbid/8707078795398309153 Change-Id: I16374bd0cc573919ecdba08192b70ecde021e9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6829188 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2553} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Merge-Approval-Bypass: Chrome release infra Change-Id: I522b3c5fe4b121c90d6d7df7671a091ef0cb6d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6829221 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2554} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Uploaded by https://ci.chromium.org/b/8707058641026848465 CrOS-LKGM: 16328.46.0 Merge-Approval-Bypass: Automated LKGM update Cr-Original-Build-Id: 8707058641026848465 Change-Id: I91b67a9aebd0e51bc8542ccbfa4c99de5ff1118d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6834053 Bot-Commit: ChromeOS Release Bot (Robot) <[email protected]> Commit-Queue: ChromeOS Release Bot (Robot) <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2555} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Binary-Size: Size increase is unavoidable Merge-Approval-Bypass: Chromium translation automation Change-Id: I89a92eced25d22788115a554c142466f4a2f368e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6833664 Auto-Submit: Chrome Release Translation Dump <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2556} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Automatic update for 2025-08-09 UTC Merge-Approval-Bypass: pki-metadata-updater Change-Id: I185485411ef9d5abf646bbaed5f14f3268fff50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6832621 Bot-Commit: PKI Metadata Updates Bot <[email protected]> Commit-Queue: PKI Metadata Updates Bot <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2557} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Merge-Approval-Bypass: Chrome release infra Change-Id: I93ae5e4c6295b9e08bc9eab74c68f5234b5f3e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6830430 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2558} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Uploaded by https://ci.chromium.org/b/8706968193318814385 CrOS-LKGM: 16328.47.0 Merge-Approval-Bypass: Automated LKGM update Cr-Original-Build-Id: 8706968193318814385 Change-Id: I41f2e890f75ec9532dbd7fde447cd1836ccb22f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6834428 Commit-Queue: ChromeOS Release Bot (Robot) <[email protected]> Bot-Commit: ChromeOS Release Bot (Robot) <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2559} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Binary-Size: Size increase is unavoidable Merge-Approval-Bypass: Chromium translation automation Change-Id: I6d98636ae26685e14cd2cc46b50ca38a9c2a082d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6830096 Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: Chrome Release Translation Dump <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2560} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Merge-Approval-Bypass: Chrome release infra Change-Id: I18f9f43dd5f42aadfc9fb9f567ee42dff40f77d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6834973 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2561} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
…atures Original change's description: > [mtb-cct] Filter out the fallback menu item for new dynamic features > > New dynamic features being added to CPA should have a fallback menu. > We allow ony price tracking/insights for now. > > Bug: 436955143 > Change-Id: I238fcbe0eb2a6f38a6043a18baa3a641d1a3d0bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6826534 > Commit-Queue: Jinsuk Kim <[email protected]> > Reviewed-by: Sinan Sahin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1498347} Bug: 437149409,436955143 Change-Id: I238fcbe0eb2a6f38a6043a18baa3a641d1a3d0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6829840 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2562} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Uploaded by https://ci.chromium.org/b/8706877542697927537 CrOS-LKGM: 16328.48.0 Merge-Approval-Bypass: Automated LKGM update Cr-Original-Build-Id: 8706877542697927537 Change-Id: I51181d0ea8889d9455c58019070527eecf9507b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6835656 Bot-Commit: ChromeOS Release Bot (Robot) <[email protected]> Commit-Queue: ChromeOS Release Bot (Robot) <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2563} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Binary-Size: Size increase is unavoidable Merge-Approval-Bypass: Chromium translation automation Change-Id: I62bd3bf8511bbca22a0356f7dab5d067461dd342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6836209 Auto-Submit: Chrome Release Translation Dump <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2564} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Change-Id: I3e67a0b6131426784511fe63b1ca7760d14003c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6837016 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2565} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
The code path for featureless matching only considered the first simple selector instead of the whole complex selector. First, the whole compound must be considered, then if there is a combinator the selector matching must fail since the featureless element cannot be combined with other elements. Re-enable flag that was set to 'test' in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/6772923 Bug: 432839793, 378966977 Fixed: 437848499 (cherry picked from commit 972d7b5) Change-Id: I40792bc3531a3c1ffe99022ff54b8506709c53c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6773592 Reviewed-by: Kevin Babbitt <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1490224} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6836371 Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2566} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll src/third_party/skia in M139 from cbc694239b06 to 2d6f1aa4be9c Commits rolled: https://skia.googlesource.com/skia.git/+log/cbc694239b06..2d6f1aa4be9c Generated by: http://go/bbid/8706818312200989409 Change-Id: Ie4e52ae0712dda23cbd5f576ad31d52c02de7108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6837136 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2567} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
This CL is a cherry-pick to M139 of CL:6779234 as requested in the linked crbug. If the renderer process crashes while a drag and drop is happening, the Window object for the source_window in DesktopDragDropClientWin::StartDragAndDrop will be freed. When the drag and drop is finished, the function will try to access the freed object, causing a use after free exception. This CL fixes this issue by temporarily adding the drag and drop client as an observer of the Window. The Window will notify it's observers when it's being destroyed, and with this we can avoid accessing the freed object. I was able to reproduce the crash following the steps in the linked bug, and stopped observing after the changes in this CL were implemented. (cherry picked from commit a4c579c) Bug: 432497641 Change-Id: Ic05aadcd9005c9f5eb8b660a7d5a182b859e62eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779234 Reviewed-by: David Bienvenu <[email protected]> Reviewed-by: Robert Liao <[email protected]> Commit-Queue: Gaston Rodriguez <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1492096} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6816386 Cr-Commit-Position: refs/branch-heads/7258@{#2568} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Original change's description: > Fix use-after-free in TailoredSecurityConsentedModal > > This CL fixes the crash by adding checks to ensure that the WebContents > is valid and not in the process of being destroyed before it is > accessed. An additional null check for the Profile is also added for > robustness. > > Bug: 416431488 > Change-Id: I05f9848e07bcf005a3f15a3a0df0b2a82e69e3d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6677433 > Reviewed-by: Xinghui Lu <[email protected]> > Commit-Queue: Zack Han <[email protected]> > Reviewed-by: Javier Castro <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1493556} Bug: 435173344,416431488 Change-Id: I05f9848e07bcf005a3f15a3a0df0b2a82e69e3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6837976 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2569} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Switches Dawn's Win/ARM64 trybots to target the GPU builderless pool. max_concurrent_builds for affected builders are set to the capacity for the relevant builderful pool. (cherry picked from commit dca58d6) Bug: 375244064 Fixed: 437421610 Change-Id: Ic13410b3c33b68518afa4dd5e1dd0df93f497358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6813300 Reviewed-by: Yuly Novikov <[email protected]> Commit-Queue: Yuly Novikov <[email protected]> Auto-Submit: Brian Sheedy <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1496333} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6838097 Commit-Queue: Brian Sheedy <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2570} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Merge-Approval-Bypass: Chrome release infra Change-Id: Ibcbb1ccd1ba34c306b0155e2be8318486366c59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6837379 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2571} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Merge-Approval-Bypass: Chrome release infra Change-Id: Ie7de8399ba6a9bdfdd292f0ce512c376dd914a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6838956 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2572} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Win32 PGO profile from chrome-win32-7258-1755755300-220c64d7b064695d8f49f635ec6fb3c66d662481-628487dee44893b82daf802a05b33cecff646778.profdata to chrome-win32-7258-1755775639-5fc246dad47b9b28808ea5c289a632c565ced793-75d3c3018594e8042a9ee16b7d7676de6c348937.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m139.try:win-chrome Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I0b2cca7e45e9a20492acc7d839160a5d4265c43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871295 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2764} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Android ARM64 PGO profile from chrome-android64-7258-1755785609-73a3ded04e669b42a62319b9ae8311c5975c8061-880334459cd4331583e60abcd5d040643421171e.profdata to chrome-android64-7258-1755790563-951e7d570d3a1cefb4f6102f35d54576ae872b17-a7a0decb0767c20266a4a0878097cffcee711f21.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: Ibeb0a796a31322a30cdb3927ec12978a0a47ce8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6872353 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2765} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-7258-1755790563-4bf0d8839feba76733716559d1b44d30173572c4-a7a0decb0767c20266a4a0878097cffcee711f21.profdata to chrome-mac-arm-7258-1755797201-d8399b3db2b916fe3887154dcf18f31d5ddd056b-84c6b233aab9dc8ed130d8265dce3a386da58ab9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I00585f902d37aee450d1e96ecc165c227efe99dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871884 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2766} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Original change's description: > Ensure that `zooom_bubble_` is valid after calling ShowForReason > > This is a temporary fix. For some reason, `zoom_bubble_` become null > after calling ShowForReason. For now, `zoom_bubble_` is checked after to > avoid dereferencing a null point. > > A more robust fix for this fix is ongoing on the CL > https://chromium-review.googlesource.com/c/chromium/src/+/6803084 > > Bug: 434615869 > Change-Id: I6838ff9b3200cb6829c12384f0313761c91a9c3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6846959 > Commit-Queue: Daniel Soromou <[email protected]> > Reviewed-by: Eshwar Stalin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1500926} Bug: 440147462,434615869 Change-Id: I6838ff9b3200cb6829c12384f0313761c91a9c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6870731 Reviewed-by: Daniel Soromou <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2767} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Win64 PGO profile from chrome-win64-7258-1755732378-d8680d7a8f4c7ff566e28373690bcf4fa596039c-ae2f59e9ce4b1c0bbdf29475448df4af33d6d5d1.profdata to chrome-win64-7258-1755755300-d97404097815945c2a6c428f3fc41dfdaaf4c0d6-628487dee44893b82daf802a05b33cecff646778.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m139.try:win64-chrome Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I6dc4945a12aaeabdf9942434f13fc912e95500fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6869040 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2768} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Android ARM64 PGO profile from chrome-android64-7258-1755790563-951e7d570d3a1cefb4f6102f35d54576ae872b17-a7a0decb0767c20266a4a0878097cffcee711f21.profdata to chrome-android64-7258-1755795632-8e2b529d51115664c3d6025b7788b9c0dbe11e4c-5229fb3a18b6884d27b93b4b2d24036ed432d06f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I1a7d7d03234ea9fbe3ab8a903ca3be1d0dc15cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6872303 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2769} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-7258-1755797201-d8399b3db2b916fe3887154dcf18f31d5ddd056b-84c6b233aab9dc8ed130d8265dce3a386da58ab9.profdata to chrome-mac-arm-7258-1755805690-d7c30931ddbfd2dd01d27636d5291d0380b3ec04-11bf658ea0d6bb94f6fcb248d9608bc75b5f48fb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: Iff0bcb4227eb61f7dfcc364ed084d2881b7a4baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6872311 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2770} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Android ARM64 PGO profile from chrome-android64-7258-1755795632-8e2b529d51115664c3d6025b7788b9c0dbe11e4c-5229fb3a18b6884d27b93b4b2d24036ed432d06f.profdata to chrome-android64-7258-1755800660-c7e9dca9ff93d06999701c075bf0e907e561b8fb-d1b5f30189263e95ec6d7289c135384a15223169.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I17df78ba11ca47e452b4cb94d3e69a1d6c913d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6872723 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2771} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
These seem to be dependent on the behavior established by OptimizeServiceWorkerStartRequests. With the feature disabled, they appear to be highly flaky. That feature flag is causing breakage in Chrome, so it has to be disabled. To allow for that, we need to temporarily disable this test too. (cherry picked from commit 9454c78) Bug: 440219099 Change-Id: I0e597af1440133cb5ac9cc1a7cc548b8edfe2e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6869030 Commit-Queue: Andrea Orru <[email protected]> Reviewed-by: Emilia Paz <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1504298} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871250 Commit-Queue: Srinivas Sista <[email protected]> Owners-Override: Srinivas Sista <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2772} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll src/v8 in M139 from 4d36678284f9 to a0a7886d6b37 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/4d36678284f9..a0a7886d6b37 Generated by: http://go/bbid/8705887822415857137 Merge-Approval-Bypass: Chrome DEPS-autoroller Change-Id: I4f0134d2b0403c1611ac92cc4a3d23fd10ec0117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871398 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7258@{#2773} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
crash keys in Dump without crash from crash reports shows that video capture path on windows is using ProduceDawn without setting the shared image usage as gpu::SHARED_IMAGE_USAGE_WEBGPU_READ during shared image creation. This CL fixes that to add gpu::SHARED_IMAGE_USAGE_WEBGPU_READ to shared image usage used for creating a shared image in Video capture path. (cherry picked from commit 2592445) Bug: 435484875, 439837115 Change-Id: I53c93059bfe3b1afe65acdb532b910709d661a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825309 Commit-Queue: vikas soni <[email protected]> Reviewed-by: Sunny Sachanandani <[email protected]> Reviewed-by: Stefan Zager <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1498465} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6871298 Cr-Commit-Position: refs/branch-heads/7258@{#2774} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-7258-1755805690-d7c30931ddbfd2dd01d27636d5291d0380b3ec04-11bf658ea0d6bb94f6fcb248d9608bc75b5f48fb.profdata to chrome-mac-arm-7258-1755810344-02f8d8c4ec078d4e5d9e942846395c15da13ba67-39c391d4983e8fa3086a2066bc6737e1bf3f05c6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I27c109835df01cc90c14c354f4f7cba59b3c4606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6872952 Bot-Commit: chromium-autoroll <[email protected]> Commit-Queue: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2775} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
Roll Chrome Android ARM64 PGO profile from chrome-android64-7258-1755800660-c7e9dca9ff93d06999701c075bf0e907e561b8fb-d1b5f30189263e95ec6d7289c135384a15223169.profdata to chrome-android64-7258-1755805690-19ae375efe37a22336c5efd1352fa8fdf543b10d-11bf658ea0d6bb94f6fcb248d9608bc75b5f48fb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-stable Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium stable branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: Ibb4cbc8367a74294153c638ec4e29cae132ff18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6872863 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#2776} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
…ge/histrograms.xml
Merging v138 To v139 for Taktak 1.1.1 development
…ension install Introduce the TAKTAK_ENABLE_BUBBLE_GOOGLE_SIGNIN_PROMO_VIEW build flag. This flag allows the Google Sign In view to be disabled at build time, offering a more efficient alternative to commenting out code lines. It reduces merge conflicts and allows easy re-enabling of the feature.
…cenarios such as subframe navigations, prerender activations, or redirect chains
Merge v139 to v140
nyinyithann
pushed a commit
that referenced
this pull request
Oct 5, 2025
This array is not meant for internal translations. Instead, it is meant for strings that are not part of the shippable binaries. There is no list for internal grit files. Merge-Approval-Bypass=Fix translation pipeline (cherry picked from commit 5fdd96a) Change-Id: I7693fd7d8399d7adee8965ee95d681339189d75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6908836 Auto-Submit: Tomasz Wiszkowski <[email protected]> Reviewed-by: Harry Souders <[email protected]> Owners-Override: Harry Souders <[email protected]> Commit-Queue: Tomasz Wiszkowski <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1509759} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6909763 Commit-Queue: Harry Souders <[email protected]> Reviewed-by: Tomasz Wiszkowski <[email protected]> Cr-Commit-Position: refs/branch-heads/7390@{#22} Cr-Branched-From: d481efc-refs/heads/main@{#1509326}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.