don't quote symbols for cl-case

[mrhmouse]

By quoting these symbols, we're actually matching against either the symbol being quoted (e.g. getStatuses) or against the symbol quote

cl-case does produce warnings for this when jiralib.el is compiled

[ahungry]

Awesome catch, thank you.

I'm curious, what benefit does the extra paren set around the keyword serve? (let's pretend I'm still getting my coffee injection to wake up and fully turn on my brain 🤣 )

(setq mymethod "getIssue")

;; "Issue"
(cl-case (intern mymethod)
  ('getIssue (print "Issue"))
  ('getComments (print "Comments")))

;; "Issue"
(cl-case (intern mymethod)
  ((getIssue) (print "Issue"))
  ((getComments) (print "Comments")))

;; "Issue"
(cl-case (intern mymethod)
  (getIssue (print "Issue"))
  (getComments (print "Comments")))

(setq notmymethod "quote")

;; "Issue"
(cl-case (intern notmymethod)
  ('getIssue (print "Issue"))
  ('getComments (print "Comments")))

;; nil
(cl-case (intern notmymethod)
  ((getIssue) (print "Issue"))
  ((getComments) (print "Comments")))

;; nil
(cl-case (intern notmymethod)
  (getIssue (print "Issue"))
  (getComments (print "Comments")))

I see your change will fix the compilation error (nice!) and the logic error where we could have dispatched to the first clause if someone passed in the literal word "quote" - but is the bottom option without the extra parens sufficient?