[AAASM-3514] ♻️ (dashboard): Harden Audit Log page — Sonar fixes + tests

[Chisanan232]

Description

Fixes the SonarCloud Reliability/Maintainability issues reported on the dashboard
Audit Log page and broadens its test coverage. Refactor-only — no behaviour
change for the existing (string-valued) payload inputs.

SonarCloud fixes:

• dashboard/src/features/audit/logs.ts L93 — typescript:S6551: p.operation ?? ''
  could stringify a non-string operation as [object Object]. Now narrowed to
  typeof p.operation === 'string' ? p.operation : '' before .toUpperCase().
• dashboard/src/features/audit/logs.ts L93 — typescript:S4624: the nested
  byte-size template literal is lifted into a named sizeSuffix const.
• dashboard/src/pages/AuditLogPage.tsx L188 — typescript:S3358: the nested
  isError ? … : isLoading ? … : <table> ternary is replaced by a body
ReactNode chosen with an explicit if/else chain before the return.

Tests:

• logs.test.tsx — payloadSummary FileOp coverage (object-valued / missing /
  non-string operation, MB suffix on/off), ToolCall error / NetworkCall /
  ApprovalEvent branches, oversized-dump truncation; extractDecision
  non-string / empty / non-object payloads; zero-seq auditEventHref.
• AuditLogPage.test.tsx — allow / em-dash decision chips, unknown event-type
  label fallback, agent-select option set, combined type + search filtering,
  loading state, agent link.

Type of Change

• ♻️ Refactoring

Breaking Changes

• No

For string operation values the summary output is byte-for-byte identical;
only previously-malformed non-string inputs change from [OBJECT OBJECT] to an
empty verb.

Related Issues

• Related Jira ticket: AAASM-3514

Testing

• Unit tests added / updated
• Manual testing performed

Validation (in dashboard/): pnpm type-check, pnpm lint, pnpm build, and
pnpm test (147 files / 1322 tests) all green.

Checklist

• Code follows project style guidelines
• Self-review of the diff completed
• Documentation updated if behaviour changed (n/a — no behaviour change)
• All CI checks passing
• Commits are small and follow the Gitmoji convention

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
dashboard/src/pages/AuditLogPage.tsx	76.00%	4 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

[Chisanan232]

🔎 Review (Claude Code) — ready for approval

CI: ✅ All green — 0 failures (codecov/patch acceptance is non-blocking).

Scope vs AAASM-3514: ✅ Fixes all 3 listed SonarCloud issues, refactor-only (string-input output unchanged):

• audit/logs.ts L93: S6551 → typeof p.operation === 'string' ? p.operation : '' (no more [object Object] for non-string operation); S4624 → nested byte-size template lifted into a named sizeSuffix const
• AuditLogPage.tsx L188: S3358 → nested ternary flattened into an if/else if/else choosing a body: ReactNode, rendered as {body} (identical output)

Tests (2-2): +20 cases — logs.test.tsx (object/missing/non-string payload fields, MB-suffix, tool/network/approval branches, truncation; extractDecision/auditEventHref edges) + AuditLogPage.test.tsx (allow/em-dash chips, unknown-type fallback, agent-select, combined type+search filtering, loading). Suite 1322 pass; lint/type-check/build clean.

Verdict: Scope-complete, correct, green. The one intentional behaviour note (non-string operation → empty verb instead of [OBJECT OBJECT]) is the S6551 fix itself. Ready to approve & merge.