[AAASM-4263] 🚨 (tests): Fix pytest.raises block scope violations#225
Merged
Conversation
…ramework Move args assignment outside pytest.raises() block to ensure only the invoke method under test can throw the expected exception. Resolves SonarCloud rule python:S5778. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move ctx assignment outside pytest.raises() block to ensure only the run_async method under test can throw the expected exception. Resolves SonarCloud rule python:S5778. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move run_id assignment outside pytest.raises() block to ensure only the on_tool_start method under test can throw the expected exception. Resolves SonarCloud rule python:S5778. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…h Agent Move run_id assignment outside pytest.raises() block to ensure only the on_tool_start method under test can throw the expected exception. Resolves SonarCloud rule python:S5778. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move run_id assignment outside pytest.raises() block to ensure only the on_tool_start method under test can throw the expected exception. Resolves SonarCloud rule python:S5778. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…gent Move run_id assignment outside pytest.raises() block to ensure only the on_tool_start method under test can throw the expected exception. Resolves SonarCloud rule python:S5778. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Contributor
Author
Claude Code ReviewCI Status✅ All CI checks passed (22/22 SUCCESS) Scope Coverage Review
Side Effect Analysis
Recommendation✅ Ready for merge - meets all acceptance criteria 🤖 Reviewed by Claude Code |
Chisanan232
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytest.raises()blocks across 6 test filesTest plan
pytest python/*/tests/test_smoke.pyCloses #224
🤖 Generated with Claude Code