Skip to content

[AAASM-2642] ✅ (python-sdk): Verify AAASM-2561 thin pyo3 shim acceptance criteria#81

Merged
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-2642/test/verify_thin_shim
Jun 6, 2026
Merged

[AAASM-2642] ✅ (python-sdk): Verify AAASM-2561 thin pyo3 shim acceptance criteria#81
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-2642/test/verify_thin_shim

Conversation

@Chisanan232
Copy link
Copy Markdown
Contributor

Description

Verification subtask for Story AAASM-2561 (Python thin pyo3 shim over aa-sdk-client). Adds verification-reports/verification-report-AAASM-2561.md. Stacked on #79 and #80 (base master).

Verified the acceptance criteria end-to-end:

  • Thin shim: RuntimeClient.connect/send_event/close delegate to aa_sdk_client::AssemblyClient; no local UDS transport / codec / policy round-trip remains.
  • uv sync + pytest green: 418 passed, 10 skipped (pure-Python install / CI path).
  • PyO3 extension builds: maturin develop builds + installs agent_assembly._core; cargo build is warning-free.
  • No duplicate runtime-client logic; no security authority in the shim (advisory preflight via aa-sdk-client).
  • Native built run: AAASM_RUN_NATIVE_CORE_TESTS=1 pytest → 426 passed, 4 skipped — gated native runtime tests (real UDS mock runtime) and FFI benchmarks pass.

Two findings were fixed during verification (folded into the impl PRs):

  1. GIL deadlock under aa-sdk-client's bounded/blocking channel → release the GIL in send_event ([AAASM-2640] ♻️ (aa-ffi-python): Delegate RuntimeClient transport to aa-sdk-client #79, 12fe563).
  2. Pre-existing benchmark bug — invalid AuditEntry payload → valid payload so the bench exercises the FFI path ([AAASM-2641] ♻️ (python-sdk): Align _core exports + native tests to the thin shim #80, c0972d1).

Type of Change

  • ♻️ Refactoring (verification / docs)

Breaking Changes

  • No

Related Issues

  • Related JIRA ticket: AAASM-2642 (Story AAASM-2561, Epic AAASM-2552)

Testing

  • cargo build (0 warnings) + maturin develop build the PyO3 extension.
  • pytest green without native (418 passed) and with native (426 passed).
  • Gated native runtime tests + FFI benchmarks pass against the aa-sdk-client delegation.

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • Documentation updated if needed
  • All tests passing

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chisanan232 Chisanan232 force-pushed the v0.0.1/AAASM-2642/test/verify_thin_shim branch from 9bd5c79 to 60da87b Compare June 6, 2026 00:48
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 6, 2026

@Chisanan232
Copy link
Copy Markdown
Contributor Author

🤖 Claude Code — review result

CI: ✅ green (21 pass / 4 skip; SonarCloud finished green). BLOCKED is solely REVIEW_REQUIRED. Stacked on #79/#80.

Scope vs AAASM-2642: ✅ complete — adds verification-reports/verification-report-AAASM-2561.md recording end-to-end AC verification:

  • cargo build 0 warnings; maturin develop builds + installs agent_assembly._corePyO3 extension builds.
  • pytest green without native (418 passed) and with native built (426 passed) — gated native runtime tests (real UDS mock runtime) + FFI benchmarks pass against the aa-sdk-client delegation.
  • Confirms no duplicate transport remains and the shim holds no security authority.

Story AAASM-2561 acceptance criteria — all met. (AC's "no duplicate in agent-assembly" is Story 9 / AAASM-2562 scope — removing the fat monorepo aa-ffi-* — and is out of this Story.)

Verdict: ✅ Ready to approve & merge last (after #79 and #80).

Record AC verification for the Python thin pyo3 shim: cargo build (0
warnings) + maturin extension build, pytest green with and without the
native module (418 / 426 passed), gated native runtime tests and FFI
benchmarks passing against the shared aa-sdk-client delegation, plus the
two findings fixed during verification (GIL release on send_event; valid
AuditEntry payload in the benchmark).
@Chisanan232 Chisanan232 force-pushed the v0.0.1/AAASM-2642/test/verify_thin_shim branch from 60da87b to c376bd1 Compare June 6, 2026 01:04
@Chisanan232 Chisanan232 merged commit 1d76525 into master Jun 6, 2026
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-2642/test/verify_thin_shim branch June 6, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant