[AAASM-2642] ✅ (python-sdk): Verify AAASM-2561 thin pyo3 shim acceptance criteria#81
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
9bd5c79 to
60da87b
Compare
|
10 tasks
Contributor
Author
🤖 Claude Code — review resultCI: ✅ green (21 pass / 4 skip; SonarCloud finished green). Scope vs AAASM-2642: ✅ complete — adds
Story AAASM-2561 acceptance criteria — all met. (AC's "no duplicate in Verdict: ✅ Ready to approve & merge last (after #79 and #80). |
Record AC verification for the Python thin pyo3 shim: cargo build (0 warnings) + maturin extension build, pytest green with and without the native module (418 / 426 passed), gated native runtime tests and FFI benchmarks passing against the shared aa-sdk-client delegation, plus the two findings fixed during verification (GIL release on send_event; valid AuditEntry payload in the benchmark).
60da87b to
c376bd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Verification subtask for Story AAASM-2561 (Python thin pyo3 shim over
aa-sdk-client). Addsverification-reports/verification-report-AAASM-2561.md. Stacked on #79 and #80 (basemaster).Verified the acceptance criteria end-to-end:
RuntimeClient.connect/send_event/closedelegate toaa_sdk_client::AssemblyClient; no local UDS transport / codec / policy round-trip remains.uv sync+pytestgreen: 418 passed, 10 skipped (pure-Python install / CI path).maturin developbuilds + installsagent_assembly._core;cargo buildis warning-free.aa-sdk-client).AAASM_RUN_NATIVE_CORE_TESTS=1 pytest→ 426 passed, 4 skipped — gated native runtime tests (real UDS mock runtime) and FFI benchmarks pass.Two findings were fixed during verification (folded into the impl PRs):
aa-sdk-client's bounded/blocking channel → release the GIL insend_event([AAASM-2640] ♻️ (aa-ffi-python): Delegate RuntimeClient transport to aa-sdk-client #79,12fe563).AuditEntrypayload → valid payload so the bench exercises the FFI path ([AAASM-2641] ♻️ (python-sdk): Align _core exports + native tests to the thin shim #80,c0972d1).Type of Change
Breaking Changes
Related Issues
Testing
cargo build(0 warnings) +maturin developbuild the PyO3 extension.pytestgreen without native (418 passed) and with native (426 passed).aa-sdk-clientdelegation.Checklist