fix(ui): allow deleting saved module API-keys [closes #15] - #120
Draft
robotyaga-gigachain[bot] wants to merge 1 commit into
Draft
fix(ui): allow deleting saved module API-keys [closes #15]#120robotyaga-gigachain[bot] wants to merge 1 commit into
robotyaga-gigachain[bot] wants to merge 1 commit into
Conversation
Masked "pass"-type module secrets (e.g. VK_TOKEN) could not be removed: clicking the field cleared it to empty, but an empty value was treated as "no change" on save, so the key persisted. Add a per-field clear (×) button that explicitly marks the secret for deletion and sends an empty value so the backend clears it. Closes #15 Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
![robotyaga-gigachain[bot]](https://avatars.githubusercontent.com/in/4152227?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Masked
pass-type module API-keys (e.g. the VK token) in Settings → Основные → «API-ключи модулей» could not be removed once saved: focusing the field cleared the mask, but an empty value was treated as "no change" on save, so the key persisted (the only workaround was typing random characters). This adds a per-field clear (×) button that explicitly marks the secret for deletion and sends an empty value, which the backend interprets as clearing the key. Verified end-to-end (set key → clear via button → save → backend reportsfilled: false).Release Note
Saved module API-keys can now be removed directly via a clear (×) button in Settings.
Test Plan