fix: return 409 when an embedding is used by RAG - #131
Open
Absamad-dew wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
409 Conflictbefore deleting an embedding referenced by a RAG collection204 No Contentpath for unreferenced embeddingsRationale
RagCollection.embedding_idusesON DELETE RESTRICT, so deleting a referenced embedding currently reaches the database and surfaces an unhandled foreign-key error. The explicit dependency check keeps that data-integrity policy, avoids poisoning the SQLAlchemy transaction with an expected constraint failure, and gives the client an actionable response. It does not translate unrelatedIntegrityErrorexceptions into409responses.Validation
uv run --frozen ruff check giga_agent/models/rag.py giga_agent/routes/embeddings.py tests/models/test_rag_collections_repository.py tests/routes/test_embeddings_router.pyuv run --frozen ruff format --check giga_agent/models/rag.py giga_agent/routes/embeddings.py tests/models/test_rag_collections_repository.py tests/routes/test_embeddings_router.pyuv run --frozen pytest tests/routes/test_embeddings_router.py tests/models/test_rag_collections_repository.py(21 passed)Closes #86