Skip to content

Clean up test_version.py#1509

Open
jakob-keller wants to merge 2 commits intoaio-libs:mainfrom
jakob-keller:test-version-clean-up
Open

Clean up test_version.py#1509
jakob-keller wants to merge 2 commits intoaio-libs:mainfrom
jakob-keller:test-version-clean-up

Conversation

@jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Mar 19, 2026

Description of Change

Clean up test_version.py in an effort to achieve #1490

Assumptions

Marginal benefit of dependency validation in test_version.py is negligible, after removing the awscli and boto3 packaging extras in #1435 and #1440. Syntactic errors should be detected by existing tooling (uv, setuptools).

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

@gemini-code-assist
Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@jakob-keller jakob-keller force-pushed the test-version-clean-up branch from 69146b6 to 1837188 Compare March 19, 2026 15:41
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.40%. Comparing base (91997f9) to head (1837188).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   93.32%   93.40%   +0.08%     
==========================================
  Files          76       76              
  Lines        8162     8111      -51     
==========================================
- Hits         7617     7576      -41     
+ Misses        545      535      -10     
Flag Coverage Δ
no-httpx 90.21% <100.00%> (+0.07%) ⬆️
os-ubuntu-24.04 93.40% <100.00%> (+0.08%) ⬆️
os-ubuntu-24.04-arm 91.41% <100.00%> (+0.06%) ⬆️
python-3.10 91.39% <100.00%> (+0.08%) ⬆️
python-3.11 91.39% <100.00%> (+0.08%) ⬆️
python-3.12 91.39% <100.00%> (+0.08%) ⬆️
python-3.13 91.39% <100.00%> (+0.08%) ⬆️
python-3.14 93.37% <100.00%> (+0.09%) ⬆️
python-3.9 91.40% <100.00%> (+0.08%) ⬆️
unittests 93.40% <100.00%> (+0.08%) ⬆️
with-awscrt 93.04% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakob-keller jakob-keller marked this pull request as ready for review March 19, 2026 15:48
@gemini-code-assist
Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@jakob-keller jakob-keller requested a review from thehesiod March 19, 2026 15:48
@jakob-keller jakob-keller enabled auto-merge March 19, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant