Skip to content

Relax botocore dependency specification#1521

Open
claude[bot] wants to merge 1 commit intomainfrom
claude/botocore-sync
Open

Relax botocore dependency specification#1521
claude[bot] wants to merge 1 commit intomainfrom
claude/botocore-sync

Conversation

@claude
Copy link

@claude claude bot commented Mar 20, 2026

Description of Change

This PR relaxes the botocore dependency to support version 1.42.72.

Type: Relax (patch)
Botocore diff: boto/botocore@1.42.70...1.42.72

What changed in botocore

  • botocore/__init__.py: version string bump only (1.42.70 → 1.42.72)
  • botocore/handlers.py: new remove_polly_start_speech_synthesis_stream function added to BUILTIN_HANDLERS — removes an operation that requires HTTP/2 (unsupported in Python); pure sync class-attribute manipulation, no I/O, no async override needed
  • All other changes: JSON schema/model updates for batch, bedrock-agentcore, ec2, mediaconvert, observabilityadmin, polly, and endpoints.json — no code changes

What changed in aiobotocore

Version bounds updated only, no code changes.

  • pyproject.toml: botocore >= 1.42.62, < 1.42.71botocore >= 1.42.62, < 1.42.73
  • aiobotocore/__init__.py: 3.3.03.3.1
  • CHANGES.rst: added changelog entry
  • uv.lock: updated

Reviewer checklist

Please verify before approving:

  • Botocore diff reviewed — changes correctly categorized as relax vs bump
  • test_patches.py hashes are up to date
  • Version bump in __init__.py is correct (patch for relax, minor for bump)
  • CHANGES.rst entry added
  • No unrelated changes included

How to help

  • Review the botocore diff link above
  • Check aiobotocore changes match botocore
  • If something looks wrong, leave a review comment — the bot will attempt to fix straightforward issues automatically
  • Use @claude to ask questions or request modifications
  • Approve and merge when satisfied

Checklist

@claude
Copy link
Author

claude bot commented Mar 20, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.32%. Comparing base (bfce8d4) to head (cdc8519).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   93.32%   93.32%           
=======================================
  Files          76       76           
  Lines        8162     8162           
=======================================
  Hits         7617     7617           
  Misses        545      545           
Flag Coverage Δ
no-httpx 90.14% <ø> (ø)
os-ubuntu-24.04 93.32% <ø> (ø)
os-ubuntu-24.04-arm 91.35% <ø> (ø)
python-3.10 91.30% <ø> (ø)
python-3.11 91.30% <ø> (ø)
python-3.12 91.30% <ø> (ø)
python-3.13 91.30% <ø> (ø)
python-3.14 93.28% <ø> (ø)
python-3.9 91.32% <ø> (ø)
unittests 93.32% <ø> (ø)
with-awscrt 92.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thehesiod
Copy link
Collaborator

ok @jakob-keller ready for your review

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the botocore and boto3 dependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakob-keller you need to (@) at claude. Also for stuff like this have it update the prompt so it does this correctly in the future. I'll have it investigate this in #1523

@claude
Copy link
Author

claude bot commented Mar 22, 2026

Botocore 1.42.73 is available but requires code changes. Upgrade is blocked on this PR.

Botocore diff (1.42.72 → 1.42.73): boto/botocore@1.42.72...1.42.73

What changed:

  • botocore/handlers.py: Added remove_polly_start_speech_synthesis_stream (sync-only, no async override needed)
  • botocore/httpchecksum.py: Bug fix in _apply_request_trailer_checksum — aiobotocore overrides this function and needs the same fix

The _apply_request_trailer_checksum fix in botocore allows non-seekable bodies to still get X-Amz-Decoded-Content-Length set if the caller pre-set Content-Length, and unconditionally removes Content-Length for chunked transfer (rather than only when content length is known). This same fix needs to be applied to aiobotocore/httpchecksum.py.

A bump PR (minor version) will be created once this PR is merged or closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants