Fix connection busy race condition #470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er command' error This commit addresses issue aio-libs#468 where concurrent cursor operations on the same connection could cause race conditions leading to the error: 'DBAPIError: (pyodbc.Error) (HY000, [HY000] [Microsoft][ODBC Driver 18 for SQL Server]Connection is busy with results for another command (0))' Changes made: - Added asyncio.Lock to Connection class to synchronize cursor operations - Protected cursor creation and cleanup with the lock to prevent race conditions - Enhanced error detection in utils.py to handle 'Connection is busy' errors - Added comprehensive tests to verify the fix works correctly The fix ensures that: 1. Cursor operations are properly serialized 2. Cleanup operations don't interfere with new cursor creation 3. The 'Connection is busy' error is properly detected and handled 4. Backward compatibility is maintained Fixes aio-libs#468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist