Skip to content

Reduce findHeaderIndex usage #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce findHeaderIndex usage #1317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions epoxy-adapter/src/main/java/com/airbnb/epoxy/stickyheader/StickyHeaderLinearLayoutManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class StickyHeaderLinearLayoutManager @JvmOverloads constructor(

// There is no header above or the position is a header.
val headerIndex = findHeaderIndexOrBefore(position)
if (headerIndex == -1 || findHeaderIndex(position) != -1) {
if (headerIndex == -1 || headerPositions[headerIndex] == position) {
super.scrollToPositionWithOffset(position, offset)
return
}
Expand All @@ -142,7 +142,7 @@ class StickyHeaderLinearLayoutManager @JvmOverloads constructor(
}

// Current sticky header is the same as at the position. Adjust the scroll offset and reset pending scroll.
if (stickyHeader != null && headerIndex == findHeaderIndex(stickyHeaderPosition)) {
if (stickyHeader != null && headerPositions[headerIndex] == stickyHeaderPosition) {
val adjustedOffset = (if (offset != INVALID_OFFSET) offset else 0) + stickyHeader!!.height
super.scrollToPositionWithOffset(position, adjustedOffset)
return
Expand Down