Validate symlink targets during ZIP extraction to prevent path traversal#2667
Open
rm335 wants to merge 2 commits intoairbnb:masterfrom
Open
Validate symlink targets during ZIP extraction to prevent path traversal#2667rm335 wants to merge 2 commits intoairbnb:masterfrom
rm335 wants to merge 2 commits intoairbnb:masterfrom
Conversation
Member
|
We don't want to manually modify any code under |
ec20b7f to
a6e9b04
Compare
Author
|
Good call! The embedded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.lottie(ZIP) extractionisContained(in:), but symlink targets were not — a malicious.lottiefile could create symlinks pointing to arbitrary system files (e.g.,/etc/passwd)allowedDestinationparameter toArchive.extract(_:to:...)and pass the destination directory fromunzipItem, so symlink targets (both absolute and relative) are resolved and validated before creationTest plan
swift buildsucceeds (confirmed locally).lottieZIP containing a symlink with an absolute target outside the extraction directory (e.g.,/etc/passwd) and confirm extraction throwsCocoaError(.fileReadInvalidFileName).lottieZIP containing a symlink with a relative target escaping via../../and confirm extraction throws.lottieZIP containing a symlink with a valid relative target within the extraction directory and confirm extraction succeeds