Add timm backbones to mmdet models#848
Open
ai-fast-track wants to merge 100 commits intoairctic:masterfrom
Open
Add timm backbones to mmdet models#848ai-fast-track wants to merge 100 commits intoairctic:masterfrom
ai-fast-track wants to merge 100 commits intoairctic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==========================================
- Coverage 87.62% 87.06% -0.56%
==========================================
Files 232 248 +16
Lines 4994 5367 +373
==========================================
+ Hits 4376 4673 +297
- Misses 618 694 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lgvaz
requested changes
May 22, 2021
Collaborator
lgvaz
left a comment
There was a problem hiding this comment.
Seems good on a high level, just a couple of things to address before we merge:
- Carefully handle
timmimports, right now doingfrom icevision.all import *will try to importtimmno matter if it's installed or not - remove commented out code
- rename backbone names that start with
ice
28b2ee1 to
fc28ad6
Compare
8c06be3 to
20f7fd5
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added mmdet + timm support. The API is very similar to the existing one. I separate the namespaces in order to be able to navigate through the different backbones families and have the autocompletion kicking in.
Both
mobilenetandresne(s)tbackbones plugged to aretinanetmodel are provided as an example showing how a user could add support for a specific backbone/model combination. Given we have over 250 timm backbones and over 50 mmet models, it isn’t realistic to imagine a support for all backbone/model combinations. In both the documentation and the notebook, we show all the different ways to plug a Timm backbone to an MMDetection model.closes #847