Open
Conversation
… cross-platform compatibility. - changed _token_present_in_collection to add a strict flag for token field match to prevent false positive
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="monke/bongos/postgres.py">
<violation number="1" location="monke/bongos/postgres.py:307">
Username/password/database are interpolated into the Postgres DSN without URL encoding, so credentials containing characters like @ or : break the connection string and prevent connections.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| raise ValueError("Postgres credentials need host/user or connection_string") | ||
| password = self.password or "" | ||
| base = ( | ||
| f"postgresql://{self.user}:{password}@{self.host}:{self.port}/{self.database}" |
Contributor
There was a problem hiding this comment.
Username/password/database are interpolated into the Postgres DSN without URL encoding, so credentials containing characters like @ or : break the connection string and prevent connections.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At monke/bongos/postgres.py, line 307:
<comment>Username/password/database are interpolated into the Postgres DSN without URL encoding, so credentials containing characters like @ or : break the connection string and prevent connections.</comment>
<file context>
@@ -0,0 +1,313 @@
+ raise ValueError("Postgres credentials need host/user or connection_string")
+ password = self.password or ""
+ base = (
+ f"postgresql://{self.user}:{password}@{self.host}:{self.port}/{self.database}"
+ )
+ if self.ssl is False:
</file context>
Author
|
umm idk precisely what i did that caused the google drive error to happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added monkey bongo testing for postgres, added yaml(left some logging things in code because it wouldn't work without (i kinda suck/ couldnt figure out working yaml correctly so I just tinkered with curl for a hot minute))
changed _token_present_in_collection to add a strict flag for token field match to prevent false positive
ooh ooh aah ah
this was highkey vibecoded twin 💔
Summary by cubic
Adds a Postgres bongo that creates, updates, and deletes test rows, plus a YAML config to run the end-to-end flow. Tightens deletion verification to avoid false positives and sets docker images to linux/amd64 for consistency.
New Features
Bug Fixes
Written for commit 20f3e5c. Summary will update automatically on new commits.