feat(AcePopup): adding getDataContainer and setVisibleRows methods#5708
Open
marinsokol5 wants to merge 2 commits intomasterfrom
Open
feat(AcePopup): adding getDataContainer and setVisibleRows methods#5708marinsokol5 wants to merge 2 commits intomasterfrom
marinsokol5 wants to merge 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5708 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 598 598
Lines 43593 43613 +20
Branches 7163 7163
=======================================
+ Hits 37936 37956 +20
Misses 5657 5657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akoreman
reviewed
Dec 24, 2024
| * @returns {HTMLDivElement} element | ||
| */ | ||
| popup.getDataContainer = function() { | ||
| return this.renderer.$textLayer.element; |
Contributor
There was a problem hiding this comment.
Was there a reason for exposing renderer.$textLayer.element here and not, for example, renderer.content or render.scroller? (which encompass all layers of the popup and might allow more flexibility when styling the popup)
nightwing
reviewed
Jan 16, 2025
| * Number of rows shown in the popup. | ||
| * @param {number} rows | ||
| */ | ||
| popup.setVisibleRows = function(rows) { |
Member
There was a problem hiding this comment.
Why not use popup.setOption("maxLInes", rows) instead of adding new api?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: