Handle joining an OU with a space in the name #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously attempting to join an OU with a space in the name would fail as the createcomputer= string wouldn't be passed to net ads join as a single parameter.
|
Can you add specs for this? |
|
I've just noticed (as I hit the same problem again) I hadn't responded to this. I've not really done anything with specs, so not sure how best to do this - in particular as this is a fix in the configure_active_directory template, I'm not sure what I'd really be testing here? |
vStone
added a commit
to UGent-DICT/puppet-samba
that referenced
this pull request
Mar 1, 2022
Handle joining an OU with a space in the name ajjahn#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously attempting to join an OU with a space in the name would fail as the createcomputer= string wouldn't be passed to net ads join as a single parameter.