Skip to content

Conversation

@powfix
Copy link

@powfix powfix commented Nov 29, 2024

Change onWordBoundary argument type from (BOOL ) to (BOOL) in stop and pause functions

Issue: Tts.stop() throwing an error.
#273

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powfix I would do the same on line 181 - it also throws the same error for me.

@nescroft
Copy link

nescroft commented Feb 11, 2025

yeah this method in TextToSpeech.mm has the same issue

RCT_EXPORT_METHOD(setDefaultRate:(float)rate
                  skipTransform:(BOOL *)skipTransform // not used, compatibility with Android native module signature
                  resolve:(RCTPromiseResolveBlock)resolve
                  reject:(RCTPromiseRejectBlock)reject)
{
    if(rate > AVSpeechUtteranceMinimumSpeechRate && rate < AVSpeechUtteranceMaximumSpeechRate) {
        _defaultRate = rate;
        resolve(@"success");
    } else {
        reject(@"bad_rate", @"Wrong rate value", nil);
    }
}```

@konsnos
Copy link

konsnos commented Apr 24, 2025

The changes of this PR worked on

"react-native": "0.78.2",

@HarshitMadhav
Copy link

I can confirm the PR works fine, why it is in open?

@fatidian1
Copy link

I can confirm the PR works fine, why it is in open?

@HarshitMadhav This repo is dead... I switched to expo-audio, it doesn't have only switch tts engine feature, but rest works perfect and even web platform is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants