Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes path handling issues for Windows compatibility by correcting improper usage of path.join() and string concatenation. The changes ensure cross-platform path construction works correctly on both Unix-like systems and Windows.
Key Changes:
- Corrected
path.join()calls that incorrectly included leading slashes in path segments - Fixed string concatenation used for path construction to use
path.join()properly - Added version extraction logic to make client installation path construction more robust
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/env-utils.ts | Fixed Java executable path construction to work cross-platform |
| src/service/sandbox-config.ts | Fixed config file path construction |
| src/service/sandbox-client-manager.ts | Fixed multiple path constructions, added version extraction for install path, normalized glob pattern for Windows, added null check for JAR file |
| src/cli-main.ts | Fixed edgeworker folder path construction |
| package.json | Updated glob and validator package versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
amaski
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.