This repository was archived by the owner on Jan 5, 2026. It is now read-only.
fix: ensures that DecCoin doesn't loose precision for very long numbers #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalniy
force-pushed
the
fix/dec-coin-encoding
branch
2 times, most recently
from
582f255 to
c87b9f1
Compare
stalniy
force-pushed
the
fix/dec-coin-encoding
branch
2 times, most recently
from
9f1e13c to
557a9ea
Compare
ygrishajev
previously approved these changes
Feb 27, 2025
troian
reviewed
Feb 27, 2025
troian
reviewed
Feb 27, 2025
stalniy
force-pushed
the
fix/dec-coin-encoding
branch
from
557a9ea to
973fe01
Compare
troian
approved these changes
Mar 3, 2025
troian
suggested changes
Mar 3, 2025
Member
troian
left a comment
troian
left a comment
There was a problem hiding this comment.
can you rebase it on to sdk-47 branch
Contributor
Author
|
just to double check, @troian are you asking to change PR target branch to be sdk-47 instead of main? |
Member
|
correct, those changes are comming to effect on sdk-47 upgrade |
Contributor
Author
|
well, this is now impossible because you merged my previous PR which relies on different tool to generate types. And patching should be done in a different way. The aim of this PR was to fix the current sdk version Anyway, thanks to @baktun14, I can talk to telescope owners/developers, so potentially they will do the fix on their side and we will not need to use patching and I will change the implementation in sdk-47 branch. So, let's wait for some time |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Current implementation relies on
parseInt+ devision which will loose precision for very long numbersWhat