Revert Config to old codes #264
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Mar 5, 2020
| @@ -0,0 +1,97 @@ | |||
| [assembly: System.Runtime.Versioning.TargetFrameworkAttribute(".NETFramework,Version=v4.6.1", FrameworkDisplayName=".NET Framework 4.6.1")] | |||
| namespace Hocon | |||
Member
There was a problem hiding this comment.
Should add this to .gitignore - don't want to include the .received.txt files. Only the .approved.txt files.
Contributor
Author
There was a problem hiding this comment.
sorry, I got trigger happy and clicked Commit a bit too fast
| @@ -0,0 +1,494 @@ | |||
| [assembly: System.Runtime.Versioning.TargetFrameworkAttribute(".NETFramework,Version=v4.6.1", FrameworkDisplayName=".NET Framework 4.6.1")] | |||
| /// </code> | ||
| /// </summary> | ||
| public class HoconObject : Dictionary<string, HoconField>, IHoconElement | ||
| public class HoconObject : SortedDictionary<string, HoconField>, IHoconElement |
Member
There was a problem hiding this comment.
Have this object implement IReadOnlyDictionary (or equivalent) or use a SortedDictionary internally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert Config API surface and behaviour to what it was back in 2018