[POC] Streamline IWithTimers API - #7741
Draft
Arkatufus wants to merge 2 commits into
Draft
Conversation
Arkatufus
changed the title
Arkatufus
commented
Aug 7, 2025
Comment on lines
+157
to
+168
|
|
||
| private ITimerScheduler? _timers; | ||
|
|
||
| public ITimerScheduler Timers | ||
| { | ||
| get | ||
| { | ||
| return _timers ??= new TimerScheduler(this); | ||
| } | ||
| } | ||
|
|
||
| public bool HaveTimers => _timers is not null; |
Contributor
Author
There was a problem hiding this comment.
Actual change, we move the timer into ActorCell itself, which is what being used as ActorContext inside actor message handlers. The timers instace is created lazily to save memory consuption.
The HaveTimers property is needed for cleanup purposes, we can always change this to internal
Contributor
Author
|
DocFX test failing because we delete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussing #7644
A POC to address IWithTimers
Changes
obj is IWithTimerscheck, we useContext.HaveTimersinstead (mechanism can always be changed)