-
Couldn't load subscription status.
- Fork 1.1k
[Streams] Fix StreamRefSettings.FinalTerminationSignalDeadline never initialized #7834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1.5
Are you sure you want to change the base?
[Streams] Fix StreamRefSettings.FinalTerminationSignalDeadline never initialized #7834
Conversation
|
@Arkatufus is this setting actually used anywhere currently? |
|
Its being used here: akka.net/src/core/Akka.Streams/Implementation/StreamRef/SourceRefImpl.cs Lines 250 to 258 in cc9435c
Its also used as a stream attribute, though the attribute isn't being used anywhere: akka.net/src/core/Akka.Streams/Attributes.cs Lines 927 to 931 in cc9435c
|
The
FinalTerminationSignalDeadlineproperty ofStreamRefSettingsnever get initialized from HOCON settings, it is always TimeSpan.Zero.Changes
FinalTerminationSignalDeadlineis initialized.