Skip to content

Group React dependency updates #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akunzai merged 2 commits into from
Jun 2, 2026
Merged

Group React dependency updates #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6609e6b
revert(react-sample): remove auth scheme retry
akunzai Jun 2, 2026
36333e7
chore(dependabot): group React package updates
akunzai Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ updates:
interval: monthly
cooldown:
default-days: 3
groups:
react:
patterns:
- react
- react-dom
- '@types/react'
- '@types/react-dom'
- '@vitejs/plugin-react'
- package-ecosystem: nuget
directory: /
schedule:
Expand Down
48 changes: 11 additions & 37 deletions samples/AspNetCoreReactSample/ClientApp/src/components/Login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,12 @@
import { useCallback, useEffect, useMemo, useState } from 'react';
import { UserManager } from '../api';

const MAX_RETRIES = 5;
const RETRY_DELAY_MS = 1000;

export function Login(): React.JSX.Element {
const userManager = useMemo(() => new UserManager(), []);
const [schemes, setSchemes] = useState<string[]>([]);
const [loading, setLoading] = useState(true);

const fetchSchemes = useCallback(async () => {
setLoading(true);
for (let attempt = 0; attempt < MAX_RETRIES; attempt++) {
try {
const result = await userManager.getAuthenticationSchemes();
if (result && result.length > 0) {
setSchemes(result);
setLoading(false);
return;
}
} catch {
// Transient error (e.g. proxy not ready yet), retry
}
if (attempt < MAX_RETRIES - 1) {
await new Promise((resolve) =>
setTimeout(resolve, RETRY_DELAY_MS * (attempt + 1))
);
}
}
setLoading(false);
setSchemes(await userManager.getAuthenticationSchemes());
}, [userManager]);

useEffect(() => {
Expand All @@ -38,20 +16,16 @@ export function Login(): React.JSX.Element {
return (
<>
<h1>Choose an authentication scheme</h1>
{loading ? (
<p>Loading...</p>
) : (
schemes.map((scheme) => (
<button
key={scheme}
type="button"
className="btn btn-outline-primary btn-lg mx-1"
onClick={() => userManager.signIn(scheme)}
>
{scheme}
</button>
))
)}
{schemes.map((scheme) => (
<button
key={scheme}
type="button"
className="btn btn-outline-primary btn-lg mx-1"
onClick={() => userManager.signIn(scheme)}
>
{scheme}
</button>
))}
</>
);
}
Loading