styles: case-insensitive style registration and lookup#1223
Merged
alecthomas merged 1 commit intoalecthomas:masterfrom Mar 4, 2026
Merged
styles: case-insensitive style registration and lookup#1223alecthomas merged 1 commit intoalecthomas:masterfrom
alecthomas merged 1 commit intoalecthomas:masterfrom
Conversation
11ae052 to
f9dcb36
Compare
Contributor
Author
|
I recognize that this may appear to be a broad approach to resolving #1222, but there are a few key reasons for the design:
This ensures that the library, CLI, and web interface all behave consistently. |
alecthomas
reviewed
Mar 4, 2026
Normalize style names to lowercase during registration and lookup to provide case-insensitive access across the library, CLI, and web interface. Changes: - Normalize keys to lowercase in styles.Register(). - Convert input names to lowercase in styles.Get(). - Update cmd/chroma and cmd/chromad to use these normalized keys. - Add regression tests for library and CLI case-insensitivity. - Update CI workflow to include tests for the cmd/chroma module. - Update README.md to document case-insensitive style names. Closes alecthomas#1222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize style names to lowercase during registration and lookup to provide case-insensitive access across the library, CLI, and web interface.
Changes:
styles.Register().styles.Get().cmd/chromaandcmd/chromadto use these normalized keys.cmd/chromamodule.README.mdto document case-insensitive style names.Closes #1222