Fix -validate and add -name flags#176
Merged
alecthomas merged 3 commits intoalecthomas:masterfrom Jun 12, 2025
Merged
Conversation
This flag allows selecting a subset of benchmarks to run when generating the report or validating benchmarks. This is useful during development in order to verify only newly added benchmarks as opposed to all benchmarks.
Unfortunately, benchmarks ran with testing.Benchmark() do not return an error, panic or otherwise make their calling goroutine exit early in order to signal failure. This could cause validation errors to be silently ignored when running with -validate specified. This commit addresses this issue by using a flag to detect when the test was prematurely finished to report it as an error, with a message for the user to re-run the test in a way that can actually report the error.
This validation was missing from the code.
alecthomas
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-validatefailures were not correctly detected when running the benchmarks withgo runand could cause panics.-nameis a new flag introduced to allow generating reports and validating only a subset of the tests.The individual commits have further explanation of each changeset.