Skip to content

Conversation

1yam
Copy link
Member

@1yam 1yam commented Sep 30, 2024

Description:

This PR introduces a new configuration file chains_config.json and updates the _load_account function to handle Solana accounts. These changes simplify the process of importing wallets for Solana users.

Changes:

Added: Support for Solana accounts in the _load_account function.
Created: chains_config.json for chain-specific configurations.
chains_config.json Format:
Added: Helper functions to streamline wallet importation and account management

json

{
   "path": "path",
   "chain": "chain"
}

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Sep 30, 2024
@1yam 1yam requested review from nesitor and philogicae September 30, 2024 13:43
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of things to change and improve, let's do a pair session to fix all these things.

@nesitor nesitor self-requested a review October 2, 2024 09:59
@aleph-im aleph-im deleted a comment from github-actions bot Oct 2, 2024
@nesitor nesitor force-pushed the 1yam-solana-acount branch from e272479 to 96bf68d Compare October 2, 2024 10:21
@nesitor nesitor merged commit 2790df9 into main Oct 2, 2024
13 checks passed
@nesitor nesitor deleted the 1yam-solana-acount branch October 2, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLACK This PR has critical implications and must be reviewed by a senior engineer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants