Skip to content

Conversation

1yam
Copy link
Member

@1yam 1yam commented Sep 30, 2025

Fix issue:

  1. credit_balance got replaced by credit_history & unit test mocked replaced with more cohérent value (from staging instead of fake data generated by claude)

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Sep 30, 2025
Copy link

"summary": "This PR involves a renaming of a variable from credit_balances to credit_history within the CreditsHistoryResponse class. This is a straightforward change that does not alter the functionality of the code but improves clarity and consistency. No significant risks are introduced, and the change is unlikely to introduce bugs. The associated test cases have been updated to reflect this change, ensuring that the code continues to function as expected.",
"highlights": [
{
"line": "credit_balances",
"comment": "Old variable name"
},
{
"line": "credit_history",
"comment": "New variable name"
},
{
"line": "assert len(response.credit_balances) == 3",
"comment": "Old assertion for credit balances length"
},
{
"line": "assert len(response.credit_history) == 2",
"comment": "New assertion for credit history length"
}
]
}

@1yam 1yam requested a review from nesitor September 30, 2025 10:46
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@1yam 1yam merged commit 07c6bd0 into main Sep 30, 2025
38 checks passed
@nesitor nesitor deleted the 1yam-fix-credit-system branch September 30, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLUE This PR is simple and straightforward.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants