Skip to content

Fix: Restarting the NDP Proxy sometimes crashed#538

Draft
hoh wants to merge 1 commit intomainfrom
hoh-ndpd-restart-fails
Draft

Fix: Restarting the NDP Proxy sometimes crashed#538
hoh wants to merge 1 commit intomainfrom
hoh-ndpd-restart-fails

Conversation

@hoh
Copy link
Member

@hoh hoh commented Feb 13, 2024

This is likely due because it was restarted too quickly.

Solution: Wrap the error in a custom class and retry after 5 seconds.

This is still a work in progress as a better approach should limit the frequency of restarts instead, for example using an event or queue.

@hoh hoh force-pushed the hoh-ndpd-restart-fails branch from 6b8d7f4 to 2340926 Compare March 6, 2024 14:53
@codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

❌ Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.20%. Comparing base (0b93f6a) to head (71103f6).
⚠️ Report is 505 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/network/ndp_proxy.py 20.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   35.25%   35.20%   -0.05%     
==========================================
  Files          53       53              
  Lines        4862     4880      +18     
  Branches      577      580       +3     
==========================================
+ Hits         1714     1718       +4     
- Misses       3127     3141      +14     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This is likely due because it was restarted too quickly.

Solution: Wrap the error in a custom class and retry after 5 seconds.

This is still a work in progress as a better approach should limit the frequency of restarts instead, for example using an event or queue.
@hoh hoh force-pushed the hoh-ndpd-restart-fails branch from 2340926 to 71103f6 Compare March 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant