-
Notifications
You must be signed in to change notification settings - Fork 18
ALEPH-615 Expose resources for executions #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 64.68% 64.76% +0.08%
==========================================
Files 88 88
Lines 8160 8169 +9
Branches 734 737 +3
==========================================
+ Hits 5278 5291 +13
+ Misses 2653 2647 -6
- Partials 229 231 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d76df62 to
c515807
Compare
fee8c98 to
3e33743
Compare
6713f9b to
23087df
Compare
| if getattr(volume, "size_mib", None): | ||
| disk_size_mib += volume.size_mib | ||
|
|
||
| return disk_size_mib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this if it's coming from the message itself? I don't like that the node can report whatever it wants.
Add a new
resourcesfield on existing endpoint/v2/about/executions/resourcesto expose resources for instancesRelated ClickUp, GitHub or Jira tickets : ALEPH-615
Opening this PR so we can discuss what info we need and the format.
Examples of what this endpoint will return, this is basically the same endpoint with added
resourcefield.