Menu: Allow to explicitly override if a menu url is remote or not#809
Open
anthraxx wants to merge 1 commit intoalex-shpak:mainfrom
Open
Menu: Allow to explicitly override if a menu url is remote or not#809anthraxx wants to merge 1 commit intoalex-shpak:mainfrom
anthraxx wants to merge 1 commit intoalex-shpak:mainfrom
Conversation
This can be very useful if a hugo website f.e. on GitHub pages is constructed from different individual spec repos but still represent one coherent site.
Owner
|
Hello! LGTM. I don't mind the param, but thinking should we find a better name? not sure if |
Contributor
Author
|
Sure, sounds reasonable. Do you have anything in mind? I just tried to related to the internal variable $isRemote, happy to change it to a better matching name. |
Owner
|
well, there is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be very useful if a hugo website f.e. on GitHub pages is constructed from different individual spec repos but still represent one coherent site.