Update Django-specific signature header to Signature-256#207
Open
thorrak wants to merge 3 commits intoalexa:masterfrom
Open
Update Django-specific signature header to Signature-256#207thorrak wants to merge 3 commits intoalexa:masterfrom
thorrak wants to merge 3 commits intoalexa:masterfrom
Conversation
Updates the Django-specific signature header to use SHA-256 rather than SHA-1 Fixes alexa#202
This was referenced May 23, 2023
Ensures that Django support matches the requirement for SHA-256 introduced in 1.3.3
Author
|
I additionally bumped the required version of ask-sdk-webservice-support to 1.3.3 or greater, so any new release of the django_ask_sdk package won't get used with an older ask-sdk-webservice-support version (since the headers specified for use in Django won't match the algorithm in use). An alternative (though not one I'm in favor of!) would be to do something like: ...which should work in both legacy (<1.3.3) and up-to-date (1.3.3) ask-sdk-webservice-support |
Author
|
I updated this PR to match the latest changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Django-specific signature header to use SHA-256 rather than SHA-1 in order to remain compatible with the changes from @doiron in #200 .
Motivation and Context
This fixes the bug highlighted in #202 and allows django_ask_sdk to be used with the latest ask-sdk-webservice-support
Testing
Tested on a skill I host. Allows the skill to be used with the other changes in the latest version of the django_ask_sdk
Types of changes
Checklist
License