Skip to content

WIP: Adapter architecture #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

WIP: Adapter architecture #4

wants to merge 9 commits into from

Conversation

@alexanderatallah
Copy link
Owner

@alexanderatallah alexanderatallah commented Mar 9, 2023

  • Adapters inherit from an abstract class in src/adapters/base.ts. That way we can enforce implementation of each method.
  • Adapters must also support transactions, which (for IORedis) work with a non-overlapping set of methods. so a separate class is used for that.

Thoughts? Does this work for REST-based clients?

@alexanderatallah alexanderatallah mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexanderatallah