Open
Conversation
…o infer return value types from the VM, and infer what type numbers that are passed into the VM should be converted into
OpCode definition DSL, type inference, and bug fixes
Collaborator
|
Let me know when you want to merge it, i'll review & then merge, then I can use this as a clean base for the opcode fix from before |
Owner
Author
|
@fantypants this won't be ready for merge for a while. I think using the current master for the fix should be fine, should be a change in a different file I believe, not in executor.ex |
fantypants
reviewed
Feb 22, 2019
| WaspVM.HostFunction.API.update_memory(ctx, "memory1", 32, <<75, 20, 102, 0>>) # 6689867 | ||
| end | ||
|
|
||
| defhost function1 do |
Collaborator
There was a problem hiding this comment.
Is this Legacy/Ready For Removal?
Owner
Author
There was a problem hiding this comment.
I don't believe so, pretty sure these functions are being used by the tests somewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #19 and introduces everything in #32 along with: