This repository was archived by the owner on Feb 28, 2019. It is now read-only.
Add bypass to node and xhr#20
Open
ponelat wants to merge 5 commits intoalgolia:masterfrom
Open
Conversation
Contributor
Author
|
I'll take a look at the fails, soon as I'm able. PS: Forget to mention how this would work...
|
Contributor
|
The failed tests might just be a bad state in the browser testing stack. If you had them passing locally in a browser then we could move further. Can you add some API documentation? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at a
bypassmethod which follows on #12It adds it to node and xhr ( i couldn't manually test IE, so I left XDomainRequest).
Working with the XHR native, was a real gnarly one. I had initially hoped to put in the prototype chain, but I couldn't inherit from it. I tried running the xhr methods on a non-xhr instance and failed that too. I think an actual DOM element is made for XHR, but that's just a thought.
Nodejs was simple, but we don't get the whole request. Just the url, which mitm wants to create a socket on. This is the one I actually need. I was hoping for a uniform PR, to include to all other interface.
I'll check back here to cleanup the PR as needed, there might be some travis errors...