Refactor to comply with JDK 17 code standards#39
Open
Gescof wants to merge 1 commit intoali-bouali:mainfrom
Open
Refactor to comply with JDK 17 code standards#39Gescof wants to merge 1 commit intoali-bouali:mainfrom
Gescof wants to merge 1 commit intoali-bouali:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to refactor key parts of the code to comply with JDK 17+ standards.
Specifically, these are the changes and explanation:
@Sl4jtool instead ofSystemclass standard output.tokenfromTokenentity totokenCodeandpermissionfromPermissionenum topermissionStr. This is to explicitly describe what is the property meaning since they should not have the same name as their class name.== nulland!= nullwithObjects.isNullandObjects.nonNullto follow functional programming approach.@Dataannotation with@Getter @Setter @RequiredArgsConstructor @ToStringand explicitequals hashCodemethods. Using@Datafor JPA entities is not recommended. It can cause severe performance and memory consumption issues because of lazy load with mapping entities.Tokenproperties visibility toprivateto be only accessed by their corresponding methods.tokenpropertytransientfromUserentity. See rule java:S1948.