DO-1952: Added AEM Sync to Cloudmanager repo github workflow: #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmedina-dev
requested review from
AdamJHall,
NgaNaNa,
TheOrangePuff,
crispy101,
hubertott and
porhkz
and removed request for
AdamJHall,
crispy101 and
hubertott
aaronmedina-dev
changed the title
TheOrangePuff
requested changes
Nov 7, 2025
| inputs: | ||
| # Build Configuration | ||
| skip-tests: | ||
| description: "Skip Maven test execution" |
Member
There was a problem hiding this comment.
IMO this should be the other way round, it's a double negative when written like this. Should be:
description: "Maven test execution"
required: false
default: true
Same with the skip build
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
Member
There was a problem hiding this comment.
This can be upgraded to v5 now 🙂
| runs-on: ubuntu-latest | ||
| needs: [run-tests] | ||
| if: | | ||
| always() && |
Member
There was a problem hiding this comment.
Maybe I'm misunderstanding always() but what's the point of this? 😅 Is this not the equivalent of running if true && condition?
| git config --global --add safe.directory $GITHUB_WORKSPACE | ||
| echo "✅ Git configuration complete" | ||
|
|
||
| - name: Validate required secrets |
Member
There was a problem hiding this comment.
This could happen in a predeploy step to verify these exist, then we can fail early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Screenshots (if applicable)
Test Workflow config
Command for running:
act push --workflows .github/workflows/test-aem-sync.yml -qLocal testing of workflows. Was able to test the Tests and Build, but not repo sync.
This is expected
Notes to PR author
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback