Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds workflow context start time tracking and applies consistent code style formatting across the codebase by converting comma separators to semicolons in TypeScript type definitions and interfaces.
Changes:
- Added
startfield toIWorkflowContextto track when workflows begin execution - Updated ESLint configuration to enforce semicolons and member delimiter style
- Converted all type/interface property separators from commas to semicolons throughout the codebase
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/worker/IWorkflowContext.ts | Added start: Date field to track workflow start time |
| src/worker/Worker.ts | Refactored to populate workflowContext.start from workflow instance |
| src/tests/workflows/start.ts | New test workflow that returns workflow ID and start time |
| src/tests/workflows.test.ts | Added test case validating workflow start time tracking |
| src/tests/activities/get-workflow-start.ts | New activity to retrieve workflow start time from context |
| eslint.config.js | Updated ESLint config to enforce semicolons and member delimiter style |
| package.json | Version bump to 0.6.0 and added devalue dev dependency |
| Multiple files | Applied semicolon formatting to type/interface definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
|
|
||
| void test("now", async () => { | ||
| void test("now superjson", async () => { |
There was a problem hiding this comment.
The test name "now superjson" is ambiguous. Consider renaming to something more descriptive like "now workflow with superjson serializer" to clearly indicate what is being tested.
| void test("now superjson", async () => { | |
| void test("now workflow with superjson serializer", async () => { |
| assert.ok(instance.result instanceof Date, "Expected result to be Date"); | ||
| }); | ||
|
|
||
| void test("now devalue", async () => { |
There was a problem hiding this comment.
The test name "now devalue" is ambiguous. Consider renaming to something more descriptive like "now workflow with devalue serializer" to clearly indicate what is being tested.
| void test("now devalue", async () => { | |
| void test("now workflow with devalue serializer", async () => { |
No description provided.