Skip to content

Adds StreamingDataLoader class following the OLMo-core definition, and changes grpo_fast.py to use it. #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
+1,340 −1,056
Draft

Adds StreamingDataLoader class following the OLMo-core definition, and changes grpo_fast.py to use it. #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
ca8370d
now we have an impl
finbarrtimbers Nov 17, 2025
aba8948
Cleaned up code
finbarrtimbers Nov 17, 2025
180272e
updated code
finbarrtimbers Nov 17, 2025
8696410
Added streaming data loader file.
finbarrtimbers Nov 17, 2025
9cc8cab
Cleaned up init order
finbarrtimbers Nov 17, 2025
4a68d0c
Clean up
finbarrtimbers Nov 17, 2025
ee012ab
Cleaned up PR
finbarrtimbers Nov 17, 2025
0941163
Cleaned up code. deleted unused code.
finbarrtimbers Nov 17, 2025
0c5a98d
deleted code
finbarrtimbers Nov 17, 2025
3271f4f
Updated code
finbarrtimbers Nov 17, 2025
504d13f
Fix StreamingDataLoaderConfig to pass runtime values as parameters
finbarrtimbers Nov 17, 2025
2fa3a11
Move pack_length validation to StreamingDataLoaderConfig
finbarrtimbers Nov 18, 2025
7e049b3
Move max_prompt_token_length and response_length to StreamingDataLoad…
finbarrtimbers Nov 18, 2025
c2b96fa
Move validation to StreamingDataLoaderConfig.__post_init__
finbarrtimbers Nov 18, 2025
56823d9
Move async_steps and num_samples_per_prompt_rollout to StreamingDataL…
finbarrtimbers Nov 18, 2025
6e562d8
Fix validation references in __post_init__
finbarrtimbers Nov 18, 2025
77ed3dd
Move inference_batch_size computation to setup_runtime_variables
finbarrtimbers Nov 18, 2025
3544474
Format code with ruff
finbarrtimbers Nov 18, 2025
5273b09
fixed code.
finbarrtimbers Nov 18, 2025
f71f3d2
fixed bug in metrics
finbarrtimbers Nov 18, 2025
fe2aec0
Fixed error
finbarrtimbers Nov 18, 2025
cb9ae42
added percent_solved_hist
finbarrtimbers Nov 18, 2025
4059fe5
Fixed metrics
finbarrtimbers Nov 18, 2025
346995c
fixed metrics
finbarrtimbers Nov 18, 2025
144a86f
updated code
finbarrtimbers Nov 18, 2025
19645a2
updated the code to remove extra args param.
finbarrtimbers Nov 18, 2025
e97335c
fixed tests
finbarrtimbers Nov 18, 2025
0c464c8
Fixed tests.
finbarrtimbers Nov 18, 2025
f6e420a
Fixed sharding
finbarrtimbers Nov 19, 2025
dec1b4b
Added barrier
finbarrtimbers Nov 19, 2025
1bdd302
using same accumulation steps
finbarrtimbers Nov 19, 2025
72a15e7
Updated metrics averaging.
finbarrtimbers Nov 20, 2025
cfcfb5e
updated code with debug logs
finbarrtimbers Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading