Fix file cache to support offline usage of previously downloaded files#564
Open
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Open
Fix file cache to support offline usage of previously downloaded files#564Chessing234 wants to merge 1 commit intoallenai:mainfrom
Chessing234 wants to merge 1 commit intoallenai:mainfrom
Conversation
The get_from_cache() function always made an HTTP HEAD request before checking the local cache, which meant it failed when the network was unavailable even if the file had been previously downloaded. This adds a check for existing cached files before any network calls, so that cached files are returned immediately. If no cached file exists and the network is unavailable, a clear error message is raised. Fixes allenai#535 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_from_cache()always made an HTTP HEAD request before checking the local cache, causing failures when offline even if files were previously downloaded_find_existing_cache_file()helper that checks for cached files by matching the URL hash prefix in the cache directory, avoiding any network callsrequests.head()call in a try/except forConnectionErrorso that if no cached file exists and the network is unavailable, a clear error is raised instead of an unhandled exceptionTest plan
umls) with network available, verify it caches correctlyIOErroris raised🤖 Generated with Claude Code