Don't use AX25 pointer for netmap #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a pointer for a protocol we don't use (AX25), use the ml_priv pointer in the net_device structure. This is intended as a private pointer, so it matches what netmap wants. There is still a danger that another protocol may want this pointer for its own private data, but this is detected and reported if it happens. Even though the pointer is now ml_priv instaed of ax25, the old #ifdef is still used to make the patch as small as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a pointer for a protocol we don't use (AX25), use the ml_priv pointer in the net_device structure. This is intended as a private pointer, so it matches what netmap wants. There is still a danger that another protocol may want this pointer for its own private data, but this is detected and reported if it happens.
Even though the pointer is now ml_priv instaed of ax25, the old #ifdef is still used to make the patch as small as possible.