feat: add TxEnvironment and CfgEnvironment traits#304
Open
figtracer wants to merge 1 commit intoalloy-rs:mainfrom
Open
feat: add TxEnvironment and CfgEnvironment traits#304figtracer wants to merge 1 commit intoalloy-rs:mainfrom
figtracer wants to merge 1 commit intoalloy-rs:mainfrom
Conversation
figtracer
force-pushed
the
feat/tx-cfg-environment
branch
from
52e4d41 to
9a6a435
Compare
Add TxEnvironment and CfgEnvironment traits mirroring the existing BlockEnvironment pattern, allowing network-specific transaction and config types to expose their inner revm types via mutable accessors. - TxEnvironment: wraps revm::context::TxEnv with tx_env_mut() - CfgEnvironment: wraps revm::context::CfgEnv with cfg_env_mut(), reusing the Spec associated type from the Cfg supertrait Both include blanket impls for the base revm types.
figtracer
force-pushed
the
feat/tx-cfg-environment
branch
from
9a6a435 to
85ee44d
Compare
Contributor
Author
|
update: this one is actually not that important as thought of initially; there's a much simpler way to approach this than to add these. this adds a bit of indirection but it's just better documented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TxEnvironment and CfgEnvironment traits mirroring the existing BlockEnvironment pattern, allowing network-specific transaction and config types to expose their inner revm types via mutable accessors.