refactor: storage layout in MachServiceManager #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the storage layout of the MachServiceManager contract and updates AVS configuration documentation across multiple files. The key changes include:
- Replacing the __GAP[50] with a new __DEPRECATED_SLOT204 and a reduced __GAP[49] in the storage layout.
- Updating generation block numbers and timestamps in AVS configuration details for multiple networks.
- Refreshing contract addresses in the altlayer documentation to reflect the latest deployment.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/avs-details/mainnet/xterio.md | Updated block number and timestamp |
| docs/avs-details/mainnet/soneium.md | Updated block number and timestamp |
| docs/avs-details/mainnet/gm-network.md | Updated block number and timestamp |
| docs/avs-details/mainnet/dodochain.md | Updated block number and timestamp |
| docs/avs-details/mainnet/cyber.md | Updated block number and timestamp |
| docs/avs-details/mainnet/altlayer.md | Updated block number, timestamp, and contract addresses |
| contracts/docs/storage/MachServiceManager.txt | Updated storage layout: introduced __DEPRECATED_SLOT204 and reduced __GAP array size |
Files not reviewed (1)
- contracts/src/core/MachServiceManager.sol: Language not supported
Comment on lines
44
to
+46
| |---------------------------+-----------------------------------------------------+------+--------+-------+----------------------------------------------------| | ||
| | __GAP | uint256[50] | 204 | 0 | 1600 | src/core/MachServiceManager.sol:MachServiceManager | | ||
| | __DEPRECATED_SLOT204 | uint256 | 204 | 0 | 32 | src/core/MachServiceManager.sol:MachServiceManager | | ||
| |---------------------------+-----------------------------------------------------+------+--------+-------+----------------------------------------------------| |
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment explaining the introduction of __DEPRECATED_SLOT204 and the rationale behind reducing the __GAP array size. This additional context will help maintainers understand the storage layout changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the storage layout of the
MachServiceManagercontract and documentation changes for AVS configuration details across multiple files. The most significant changes involve introducing a new deprecated storage slot in the contract and updating documentation to reflect new block generation details and contract addresses.Contract Changes:
MachServiceManagerby replacing the__GAParray of size 50 with a new__DEPRECATED_SLOT204and a reduced__GAParray of size 49 to maintain compatibility while marking a specific storage slot as deprecated. (contracts/docs/storage/MachServiceManager.txt,contracts/src/core/MachServiceManager.sol) [1] [2]Documentation Updates:
22244692to22395872and corresponding timestamps in AVS configuration files. (docs/avs-details/mainnet/altlayer.md,docs/avs-details/mainnet/cyber.md,docs/avs-details/mainnet/dodochain.md,docs/avs-details/mainnet/gm-network.md,docs/avs-details/mainnet/soneium.md,docs/avs-details/mainnet/xterio.md) [1] [2] [3] [4] [5] [6]altlayer.mdfile to reflect the latest deployed versions. (docs/avs-details/mainnet/altlayer.md)