fix(mmc): do not modify r_data in mmc_send_cmd()

Yann-lms · Yann-lms · commit bf78a6504254 · 2022-12-07T14:16:48.000+01:00
Fix MISRA C2012-17.8:
A function parameter should not be modified

Signed-off-by: Yann Gautier &lt;yann.gautier@st.com&gt;
Change-Id: I08ed4c6768c7988a98de21da181b97b0885139de
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
@@ -69,8 +69,7 @@ static int mmc_send_cmd(unsigned int idx, unsigned int arg,
 		int i;
 
 		for (i = 0; i < 4; i++) {
-			*r_data = cmd.resp_data[i];
-			r_data++;
+			r_data[i] = cmd.resp_data[i];
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,7 @@ static int mmc_send_cmd(unsigned int idx, unsigned int arg,`
`69`	`69`	`int i;`
`70`	`70`
`71`	`71`	`for (i = 0; i < 4; i++) {`
`72`		`- *r_data = cmd.resp_data[i];`
`73`		`- r_data++;`
	`72`	`+ r_data[i] = cmd.resp_data[i];`
`74`	`73`	`}`
`75`	`74`	`}`
`76`	`75`