Update opcodes and opcode creation; update or ignore failing tests #1012
+453
−776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
This PR takes the first steps towards updating to the latest ion 1.1 spec by updating the Opcode values, creation, and kinds, to match the current spec.
Tests that were identified as failing due to manually supplied binary ion have been updated though I have not verified that every test is passing correctly. Next efforts will be to validate the primitive values, and begin working on changes to containers and templates.
Throughout the unit tests I've left
TODOs to revisit failing tests (that are now ignored, or commented out) once 1.1 features are updated or implemented. These comments will serve as a way to identify tests that should be working as the efforts continue.I've also disabled the conformance tests for now, until we have read and write support since the conformance dsl relies heavily on both.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.