Skip to content

Conversation

@nirosys
Copy link
Contributor

@nirosys nirosys commented Oct 24, 2025

Issue #, if available: n/a

Description of changes:
This PR takes the first steps towards updating to the latest ion 1.1 spec by updating the Opcode values, creation, and kinds, to match the current spec.

Tests that were identified as failing due to manually supplied binary ion have been updated though I have not verified that every test is passing correctly. Next efforts will be to validate the primitive values, and begin working on changes to containers and templates.

Throughout the unit tests I've left TODOs to revisit failing tests (that are now ignored, or commented out) once 1.1 features are updated or implemented. These comments will serve as a way to identify tests that should be working as the efforts continue.

I've also disabled the conformance tests for now, until we have read and write support since the conformance dsl relies heavily on both.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 48.43750% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.76%. Comparing base (f433eb4) to head (e61c9f7).

Files with missing lines Patch % Lines
src/lazy/binary/raw/v1_1/type_descriptor.rs 1.56% 63 Missing ⚠️
src/lazy/binary/raw/v1_1/reader.rs 96.77% 2 Missing ⚠️
src/lazy/binary/raw/v1_1/struct.rs 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (48.43%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (74.76%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##            ion11    #1012      +/-   ##
==========================================
- Coverage   78.34%   74.76%   -3.58%     
==========================================
  Files         138      138              
  Lines       34182    33997     -185     
  Branches    34182    33997     -185     
==========================================
- Hits        26780    25418    -1362     
- Misses       5340     6734    +1394     
+ Partials     2062     1845     -217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nirosys nirosys marked this pull request as ready for review October 24, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant