Skip to content

Add flag to disable joint friction #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add flag to disable joint friction #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/jaxsim/api/actuation_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def compute_resultant_torques(

τ_friction = jnp.zeros_like(τ_references).astype(float)

if model.dofs() > 0:
# Apply joint friction only if enabled in the actuation parameters.
if model.dofs() > 0 and model.actuation_params.friction:

# Static and viscous joint friction parameters
kc = jnp.array(
Expand Down
2 changes: 2 additions & 0 deletions src/jaxsim/rbda/actuation/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import dataclasses

import jax_dataclasses
from jax_dataclasses import Static

import jaxsim.typing as jtp
from jaxsim.utils import JaxsimDataclass
Expand All @@ -15,3 +16,4 @@ class ActuationParams(JaxsimDataclass):
torque_max: jtp.Float = dataclasses.field(default=3000.0) # (Nm)
omega_th: jtp.Float = dataclasses.field(default=30.0) # (rad/s)
omega_max: jtp.Float = dataclasses.field(default=100.0) # (rad/s)
friction: Static[bool] = dataclasses.field(default=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can call it enable_friction or consider_friction ? to avoid misinterpretation of the value

Loading