refactor: replace JSON strings with typed proto messages in cloud tools#4583
Merged
refactor: replace JSON strings with typed proto messages in cloud tools#4583
Conversation
…l responses Cloud tool results and definitions were serialized as opaque JSON strings inside proto messages, forcing the cloud server to parse unknown JSON. Now uses proper proto message types (HostInfo, ContainerInfo, etc.) so the cloud server receives structured data it can format as needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Clean refactor — typed proto messages are strictly better than opaque JSON strings. A few observations:
Overall the direction is correct — the typed result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
result_jsonstring inCallToolResponsewith aoneof resultcontaining typed proto messages (ListHostsResult,ListContainersResult,ContainerStatsResult,ActionResult)repeated string tools_jsoninListToolsResponsewithrepeated ToolDefinition toolsExecuteTool— now returns*pb.CallToolResponsedirectlyTest plan
go build ./...)🤖 Generated with Claude Code