Skip to content

fix: resolve race condition in TestContainerStore_die #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amir20 merged 1 commit into from
Apr 5, 2026
+3 −0
Merged

fix: resolve race condition in TestContainerStore_die #4591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/container/container_store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,12 @@ func TestContainerStore_die(t *testing.T) {
},
}, nil)

ready := make(chan struct{})
client.On("ContainerEvents", mock.Anything, mock.AnythingOfType("chan<- container.ContainerEvent")).Return(nil).
Run(func(args mock.Arguments) {
ctx := args.Get(0).(context.Context)
events := args.Get(1).(chan<- ContainerEvent)
<-ready
events <- ContainerEvent{
Name: "die",
ActorID: "1234",
Expand All @@ -110,6 +112,7 @@ func TestContainerStore_die(t *testing.T) {
// Wait until we get the event
events := make(chan ContainerEvent)
store.SubscribeEvents(t.Context(), events)
close(ready)
<-events

containers, _ := store.ListContainers(ContainerLabels{})
Expand Down
Loading