refactor: preparing gradle configuration to support kmm #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polbins
force-pushed
the
main
branch
2 times, most recently
from
f637331 to
ee9deab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we can see in #114, a lot of people (including me) would love support for KMM support in Amplitude-Kotlin.
That's why I started to prepare the repository to add this support. Here's what changed and why:
build.gradleconfigs for code that can be shared, using multiplatform plugin instead of jvm onesrc/main/javatosrc/commonMain/kotlinfor those same modules, so that we all continue with this same path allowing the library to continue to evolve while we start updating the code (avoid merge conflicts later)If this gets approved and merged, I'll continue updating the common/core modules to make them multiplatform compatible, and work on an ios module later on.
Checklist