Skip to content

refactor: preparing gradle configuration to support kmm - #241

Closed
nathanfallet wants to merge 1 commit into
amplitude:mainfrom
nathanfallet:main
Closed

nathanfallet wants to merge 1 commit into
amplitude:mainfrom
nathanfallet:main

Conversation

@nathanfallet

Copy link
Copy Markdown

Summary

As we can see in #114, a lot of people (including me) would love support for KMM support in Amplitude-Kotlin.
That's why I started to prepare the repository to add this support. Here's what changed and why:

  • Rewriting build.gradle configs for code that can be shared, using multiplatform plugin instead of jvm one
  • Renaming src/main/java to src/commonMain/kotlin for those same modules, so that we all continue with this same path allowing the library to continue to evolve while we start updating the code (avoid merge conflicts later)

If this gets approved and merged, I'll continue updating the common/core modules to make them multiplatform compatible, and work on an ios module later on.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@polbins
polbins force-pushed the main branch 2 times, most recently from f637331 to ee9deab Compare June 10, 2025 21:42
@mattfeury

Copy link
Copy Markdown

this would be great. would be great to get a review from the team

@nathanfallet

Copy link
Copy Markdown
Author

I'm creating a new KMP app today, and I can see the team has not changed anything about this (no review, plan or whatever). Will have to stay with the old manual way...

@nathanfallet

Copy link
Copy Markdown
Author

I'm closing this as it is outdated. As mentioned in #114, I'll work on a wrapper library to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants