fix: guard against empty choices and message=None in LLM responses (3 sites) - #444
Open
qizwiz wants to merge 1 commit into
Open
fix: guard against empty choices and message=None in LLM responses (3 sites)#444qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guards
response.choices[0]in the FLAT and REBEL agent helpers against two crash vectors — emptychoiceslist andchoices[0].message = None:src/llm_vm/agents/FLAT/agent_helper/requests/call_open_ai.py(2 sites):src/llm_vm/agents/REBEL/utils.py(1 site):Why
The OpenAI API can return
choices=[](HTTP 200, empty list) orchoices[0].message=Nonewhen content is filtered. Without the guard, the agent crashes with an unhandledIndexErrororAttributeError— there's no outer exception handler in these paths that would catch these specific errors gracefully.Evidence
choices[0].message = NoneonPROHIBITED_CONTENTwith HTTP 200Scope
2 files, 6 lines added.